Inline reactions aren’t working for me in Firefox 88 on Xubuntu 16.04: when I select text, I can see the smiley icon next to the comment, but it disappears when I mouse over it.
This probably doesn’t count as a bug report; while some companies need to support old software for a long time, in this case, I’m just imagining jimrandomh incredulously telling me, “Wait, you’re running Firefox 88, on Xenial?! Why? What’s wrong with you? You’re a terrible person,” and me not having any satisfactory reply.
I have the same bug in Firefox 113.0.2 on Windows 11. But, it seems to depend on what I select: for some selections it works, for some selections it doesn’t.
To clarify, does this prevent you from in-line reacting or just remove your selection? (ie can you click the button and see the react palette, and what text appears there when you do?)
Selecting a part of a paragraph (or the entire paragraph, by dragging mouse from the beginning to the end) -- does not work.
Selecting the entire paragraph by double clicking—works.
Selecting across the paragraph boundary—works.
(So my hypothesis is that there is something like an invisible character after each paragraph, and a selection works only if it contains at least one such character.)
Like Vanessa described, the smiley is there, after selecting I can freely move the mouse cursor across the entire screen, but when I get the mouse cursor on the smiley, it disappears, and the text is unselected.
Here are some for me (Firefox 113.0.2, Ubuntu 22.04).
In some cases the selection (along with the smiley) completely vanishes on mouseover:
Paragraph 1: “Lorem ipsum dolor sit amet”
Paragraph 1: the whole thing
Paragraph 5: the whole thing
In some cases, the selection shrinks (and the smiley moves to where it would have been had I made the smaller selection) on mouseover:
Paragraph 2: the whole thing
Selection shrinks to end after “ali” in the word “aliquam”
Paragraph 3: the whole thing
Selection shrinks to end after “faucib” in the word “faucibus”
Paragraph 3: “Integer dictum tincidunt risus quis varius. Vestibulum erat dui, gravida et commodo”
Selection shrinks to “Integer dictum tincidunt risus quis varius. Vestibulum erat ”
Paragraph 3: “Integer dictum tincidunt risus quis varius. Vestibulum erat dui, gravida et commodo et, dapibus faucibus tortor. Ut sit amet vulputate ipsum. Morbi at blandit nibh. Sed sagittis erat dui, eget placerat dui tincidunt sit amet. Sed ex diam, auctor ut aliquet sit amet, euismod sit amet nunc”
Selection shrinks to end after “faucib” in the word “faucibus”
In some cases, the selection remains stable on mouseover:
Any of the subselections that get shrunk-to as described above
All of paragraphs 1-2
All of paragraphs 1-3
All of paragraphs 3-4
Paragraphs 1-2: “Fusce sagittis elit tellus, ultrices maximus velit ultrices eu. Mauris fermentum ipsum vel sagittis dignissim. Sed vitae sem quis dui laoreet consectetur. Cras vel est quis velit imperdiet dignissim nec non metus. Morbi at ligula dolor. [paragraph break] Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Aenean in sem at mauris euismod condimentum vel nec odio. Vivamus congue est non leo condimentum placerat. Cras interdum mauris quam, non elementum neque aliquet in. Pellentesque risus massa, aliquam id ante a, lobortis varius est. Aliquam erat volutpat.”
[EDITED per Raemon’s request to include all the text rather than using ellipses for brevity, and to put each example in a separate bullet point.]
Could you format these where each selection is just a single bullet, with only the text you highlighted? I’m finding it somewhat hard to figure out which exact quotes you mean. (It’s also much easier if you have the entire quote. It looks like you’re including ”...” to indicate “stuff in between”, but, literally just copy-pasting the whole quote is more helpful)
One background fact of what’s supposed to happen: You can only inline react on unique strings within a comment. What’s supposed to happen is that if you’ve highlighted a non-unique string, the tooltip for the button says “you haven’t selected a unique string. Please select more text.” It detects non-unique strings via a regex that doesn’t work entirely reliably (and I’m guessing works differently on some browsers?)
Reformatted in what I hope is a sufficiently helpful way.
When I select a definitely non-unique string (e.g., an instance of “amet”) and move my mouse over to the smiley face, before the selection is cancelled and the smiley face disappears there is a flash of a larger tooltippy thing which I am guessing contains the warning about non-uniqueness that you describe.
But when I select, e.g., the whole of the first paragraph, or just “Lorem ipsum dolor sit amet”, that doesn’t happen (or if it does it’s too quick for me to see).
So, if I’m understanding what you mean by “unique string” correctly (i.e., a string that occurs only once in the comment), I see different behaviours depending on whether my selection is unique or not, and I get the shrinking/vanishing selection in both cases.
(Which suggests that whatever’s going on, it probably isn’t of the form “selections thought to be unique are OK, selections thought to be non-unique misbehave”, since the unique/non-unique division is visible within the class of selections that vanish.)
Recommendation for everyone who reported bugs in this comment thread: Bug reports are quicker to do, and much easier to understand for devs, if you accompany them with screenshots or gifs of the bug behavior. There are a bunch of screen capture tools which can very easily record a gif and upload it to the internet.
For Windows I’ve recommended ShareX here before; whereas for MacOS I’ve heard that e.g. CleanShot might be able to do this (though I haven’t tried that myself). I’m not aware of any Linux versions, but they’ll surely exist, too. Plus nowadays I suspect that even the inbuilt screen capture tools on each OS can record gifs, and even if they can’t automatically upload them, you can instead just drag the final gif into the LW comment.
Inline reactions aren’t working for me in Firefox 88 on Xubuntu 16.04: when I select text, I can see the smiley icon next to the comment, but it disappears when I mouse over it.
This probably doesn’t count as a bug report; while some companies need to support old software for a long time, in this case, I’m just imagining jimrandomh incredulously telling me, “Wait, you’re running Firefox 88, on Xenial?! Why? What’s wrong with you? You’re a terrible person,” and me not having any satisfactory reply.
I have the same bug in Firefox 113.0.2 on Windows 11. But, it seems to depend on what I select: for some selections it works, for some selections it doesn’t.
To clarify, does this prevent you from in-line reacting or just remove your selection? (ie can you click the button and see the react palette, and what text appears there when you do?)
When I try to move my mouse over the smiley, both the selection and the smiley disappear before I can click it.
Gotcha. Well that’s no good. Can you give me some examples of selections that work and selections that don’t?
Selecting a part of a paragraph (or the entire paragraph, by dragging mouse from the beginning to the end) -- does not work.
Selecting the entire paragraph by double clicking—works.
Selecting across the paragraph boundary—works.
(So my hypothesis is that there is something like an invisible character after each paragraph, and a selection works only if it contains at least one such character.)
What browser/OS? (it’s definitely supposed to be able to highlight a subset of a paragraph, and which currently seems to work on Chrome 114 on MacOS)
Firefox 113.0.2 (64-bit) on Windows 10 Home
Like Vanessa described, the smiley is there, after selecting I can freely move the mouse cursor across the entire screen, but when I get the mouse cursor on the smiley, it disappears, and the text is unselected.
Here are some for me (Firefox 113.0.2, Ubuntu 22.04).
In some cases the selection (along with the smiley) completely vanishes on mouseover:
Paragraph 1: “Lorem ipsum dolor sit amet”
Paragraph 1: the whole thing
Paragraph 5: the whole thing
In some cases, the selection shrinks (and the smiley moves to where it would have been had I made the smaller selection) on mouseover:
Paragraph 2: the whole thing
Selection shrinks to end after “ali” in the word “aliquam”
Paragraph 3: the whole thing
Selection shrinks to end after “faucib” in the word “faucibus”
Paragraph 3: “Integer dictum tincidunt risus quis varius. Vestibulum erat dui, gravida et commodo”
Selection shrinks to “Integer dictum tincidunt risus quis varius. Vestibulum erat ”
Paragraph 3: “Integer dictum tincidunt risus quis varius. Vestibulum erat dui, gravida et commodo et, dapibus faucibus tortor. Ut sit amet vulputate ipsum. Morbi at blandit nibh. Sed sagittis erat dui, eget placerat dui tincidunt sit amet. Sed ex diam, auctor ut aliquet sit amet, euismod sit amet nunc”
Selection shrinks to end after “faucib” in the word “faucibus”
In some cases, the selection remains stable on mouseover:
Any of the subselections that get shrunk-to as described above
All of paragraphs 1-2
All of paragraphs 1-3
All of paragraphs 3-4
Paragraphs 1-2: “Fusce sagittis elit tellus, ultrices maximus velit ultrices eu. Mauris fermentum ipsum vel sagittis dignissim. Sed vitae sem quis dui laoreet consectetur. Cras vel est quis velit imperdiet dignissim nec non metus. Morbi at ligula dolor. [paragraph break] Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Aenean in sem at mauris euismod condimentum vel nec odio. Vivamus congue est non leo condimentum placerat. Cras interdum mauris quam, non elementum neque aliquet in. Pellentesque risus massa, aliquam id ante a, lobortis varius est. Aliquam erat volutpat.”
[EDITED per Raemon’s request to include all the text rather than using ellipses for brevity, and to put each example in a separate bullet point.]
Thanks!
Could you format these where each selection is just a single bullet, with only the text you highlighted? I’m finding it somewhat hard to figure out which exact quotes you mean. (It’s also much easier if you have the entire quote. It looks like you’re including ”...” to indicate “stuff in between”, but, literally just copy-pasting the whole quote is more helpful)
One background fact of what’s supposed to happen: You can only inline react on unique strings within a comment. What’s supposed to happen is that if you’ve highlighted a non-unique string, the tooltip for the button says “you haven’t selected a unique string. Please select more text.” It detects non-unique strings via a regex that doesn’t work entirely reliably (and I’m guessing works differently on some browsers?)
Reformatted in what I hope is a sufficiently helpful way.
When I select a definitely non-unique string (e.g., an instance of “amet”) and move my mouse over to the smiley face, before the selection is cancelled and the smiley face disappears there is a flash of a larger tooltippy thing which I am guessing contains the warning about non-uniqueness that you describe.
But when I select, e.g., the whole of the first paragraph, or just “Lorem ipsum dolor sit amet”, that doesn’t happen (or if it does it’s too quick for me to see).
So, if I’m understanding what you mean by “unique string” correctly (i.e., a string that occurs only once in the comment), I see different behaviours depending on whether my selection is unique or not, and I get the shrinking/vanishing selection in both cases.
(Which suggests that whatever’s going on, it probably isn’t of the form “selections thought to be unique are OK, selections thought to be non-unique misbehave”, since the unique/non-unique division is visible within the class of selections that vanish.)
Okay this should be working now. @Vanessa Kosoy , @Zack_M_Davis , @DanielFilan , @Viliam_Bur, checking in on how inline reacts are working for you now?
Working now. (“What browser and OS version was that again?” “Look, I procrastinated on upgrades, okay? I’m sorry!” “For our records.”)
A quick try suggests that it’s working now. I haven’t tested thoroughly.
Recommendation for everyone who reported bugs in this comment thread: Bug reports are quicker to do, and much easier to understand for devs, if you accompany them with screenshots or gifs of the bug behavior. There are a bunch of screen capture tools which can very easily record a gif and upload it to the internet.
For Windows I’ve recommended ShareX here before; whereas for MacOS I’ve heard that e.g. CleanShot might be able to do this (though I haven’t tried that myself). I’m not aware of any Linux versions, but they’ll surely exist, too. Plus nowadays I suspect that even the inbuilt screen capture tools on each OS can record gifs, and even if they can’t automatically upload them, you can instead just drag the final gif into the LW comment.
I can reproduce loss-of-selection on mouseover some of the time on up-to-date Chrome, so, I think probably not browser specific.
Wait, you’re running Firefox 88, on Xenial?! Why? What’s wrong with you? You’re a terrible person.