Could you format these where each selection is just a single bullet, with only the text you highlighted? I’m finding it somewhat hard to figure out which exact quotes you mean. (It’s also much easier if you have the entire quote. It looks like you’re including ”...” to indicate “stuff in between”, but, literally just copy-pasting the whole quote is more helpful)
One background fact of what’s supposed to happen: You can only inline react on unique strings within a comment. What’s supposed to happen is that if you’ve highlighted a non-unique string, the tooltip for the button says “you haven’t selected a unique string. Please select more text.” It detects non-unique strings via a regex that doesn’t work entirely reliably (and I’m guessing works differently on some browsers?)
Reformatted in what I hope is a sufficiently helpful way.
When I select a definitely non-unique string (e.g., an instance of “amet”) and move my mouse over to the smiley face, before the selection is cancelled and the smiley face disappears there is a flash of a larger tooltippy thing which I am guessing contains the warning about non-uniqueness that you describe.
But when I select, e.g., the whole of the first paragraph, or just “Lorem ipsum dolor sit amet”, that doesn’t happen (or if it does it’s too quick for me to see).
So, if I’m understanding what you mean by “unique string” correctly (i.e., a string that occurs only once in the comment), I see different behaviours depending on whether my selection is unique or not, and I get the shrinking/vanishing selection in both cases.
(Which suggests that whatever’s going on, it probably isn’t of the form “selections thought to be unique are OK, selections thought to be non-unique misbehave”, since the unique/non-unique division is visible within the class of selections that vanish.)
Thanks!
Could you format these where each selection is just a single bullet, with only the text you highlighted? I’m finding it somewhat hard to figure out which exact quotes you mean. (It’s also much easier if you have the entire quote. It looks like you’re including ”...” to indicate “stuff in between”, but, literally just copy-pasting the whole quote is more helpful)
One background fact of what’s supposed to happen: You can only inline react on unique strings within a comment. What’s supposed to happen is that if you’ve highlighted a non-unique string, the tooltip for the button says “you haven’t selected a unique string. Please select more text.” It detects non-unique strings via a regex that doesn’t work entirely reliably (and I’m guessing works differently on some browsers?)
Reformatted in what I hope is a sufficiently helpful way.
When I select a definitely non-unique string (e.g., an instance of “amet”) and move my mouse over to the smiley face, before the selection is cancelled and the smiley face disappears there is a flash of a larger tooltippy thing which I am guessing contains the warning about non-uniqueness that you describe.
But when I select, e.g., the whole of the first paragraph, or just “Lorem ipsum dolor sit amet”, that doesn’t happen (or if it does it’s too quick for me to see).
So, if I’m understanding what you mean by “unique string” correctly (i.e., a string that occurs only once in the comment), I see different behaviours depending on whether my selection is unique or not, and I get the shrinking/vanishing selection in both cases.
(Which suggests that whatever’s going on, it probably isn’t of the form “selections thought to be unique are OK, selections thought to be non-unique misbehave”, since the unique/non-unique division is visible within the class of selections that vanish.)
Okay this should be working now. @Vanessa Kosoy , @Zack_M_Davis , @DanielFilan , @Viliam_Bur, checking in on how inline reacts are working for you now?
Working now. (“What browser and OS version was that again?” “Look, I procrastinated on upgrades, okay? I’m sorry!” “For our records.”)
A quick try suggests that it’s working now. I haven’t tested thoroughly.