I agree. However, the way I’ve had the two generals problem framed to me, it’s not a solution unless it guarantees successful coordination. Like, if I claim to solve the halting problem because in practice I can tell if a program halts, most of the time at least, I’m misunderstanding the problem statement. I think that conflating “approximately solves the 2GP” with “solves the 2GP” is roughly as malign as my claim that the approximate solution is not the realm of theory.
I think this is very fair (and I will think about editing my post in response).
I think this is very fair (and I will think about editing my post in response).