Good catch. Don’t think I’m going to change the behavior, as there’s complex cases where there’s no obvious behavior: suppose you have a highly upvoted comment, whose parent and grandparent are both below the threshold. Do you color it in the widget differently from its parents? Do you expand both its parent and grandparent when it’s clicked on, in order that it be on the page and thus scrollable to? Do you mark its parent somehow so the reader knows that comment wouldn’t normally have been displayed?
So I think I’m OK with clicking on a comment which is hidden doing nothing. It’s maybe worth greying out such comments in the list, so as not to confuse people when nothing happens, but I feel like this mostly just ends up highlighting them, so I’m not going to put that in the main script. If you want that feature, though, I pushed it to an alternative branch on the github repo, and you can find it here. Comments will remain greyed even if you’ve un-hidden their parents, but will become scrollable to.
Good catch. Don’t think I’m going to change the behavior, as there’s complex cases where there’s no obvious behavior: suppose you have a highly upvoted comment, whose parent and grandparent are both below the threshold. Do you color it in the widget differently from its parents? Do you expand both its parent and grandparent when it’s clicked on, in order that it be on the page and thus scrollable to? Do you mark its parent somehow so the reader knows that comment wouldn’t normally have been displayed?
So I think I’m OK with clicking on a comment which is hidden doing nothing. It’s maybe worth greying out such comments in the list, so as not to confuse people when nothing happens, but I feel like this mostly just ends up highlighting them, so I’m not going to put that in the main script. If you want that feature, though, I pushed it to an alternative branch on the github repo, and you can find it here. Comments will remain greyed even if you’ve un-hidden their parents, but will become scrollable to.